From c1a4b8e701bc199ec61548a6a41be35f730aec11 Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Fri, 31 Aug 2018 00:35:52 +0200 Subject: [PATCH 1/2] updated readme files --- CHANGELOG.md | 14 ++++++++++++++ README.md | 9 ++++----- js/conf/Debug.js | 4 ++-- js/lib/VideoData.js | 7 ++++++- 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a2d7e8..82d6a49 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,20 @@ ## v3.x +### v3.1.0 + +* Fixed the issue where aspect ratio change wouldn't survive switching between fullscreen and non-fullscreen modes +* Fixed the issue where settings wouldn't survive browser restarts in Firefox + +Under the hood: + +* rewrote how settings work, swapped Comms with storage.onChanged where it made sense & as much as possible +* enabling/disabling extension (either globally or for a given site) has now instant effect (consequence of above) + +### v3.0.1 + +Minor fixes. + ### v3.0.0 Pretty much rewrote extension in more object-oriented way and sorted out spaghetti a little. Site settings and keybinds have been merged with the rest of the extension settings. Rewrote messageing. diff --git a/README.md b/README.md index ba0f199..82e1186 100644 --- a/README.md +++ b/README.md @@ -34,8 +34,8 @@ I am not actively testing extension on other sites. You can try your luck and en You can download this extension from Firefox' and Chrome's extension stores: -* [Firefox](https://addons.mozilla.org/en/firefox/addon/ultrawidify/) (v3.0.0) -* [Chrome](https://chrome.google.com/webstore/detail/ultrawidify/dndehlekllfkaijdlokmmicgnlanfjbi) (v2.2.5-ish) +* [Firefox](https://addons.mozilla.org/en/firefox/addon/ultrawidify/) +* [Chrome](https://chrome.google.com/webstore/detail/ultrawidify/dndehlekllfkaijdlokmmicgnlanfjbi) ### Beggathon @@ -178,13 +178,12 @@ They still aren't rebindable. ## Plans for the future -1. ~~Handle porting of extension settings between versions. (Some people had some issues where extension broke until reinstalled, and corrupted settings seemed to be the problem.)~~ seems to work for me? +1. Handle porting of extension settings between versions. 2. Reintroduce gradual zoom on z and u and provide a way to 'scroll' the zoomed in video up/down left/right. 3. reintroduce settings page (rebindable keys, blacklist/whitelist management, some settings for automatic aspect ratio detection) 4. site-specific options for sites that require additional CSS classes or other hacks 5. figure the best way to do GUI (injecting buttons into the player bar is not a good way. Been there, done that, each site has its own way and some appear to be impossible). Might get bumped to be released alongside #2 -6. ~~Stretch mode, because some people are very salty and toxic about the fact that this extension is here to solve a problem that's different than the one they want. More salty than me rn.~~ done -7. Improvements to automatic aspect ratio detection +6. Improvements to automatic aspect ratio detection ## Changelog diff --git a/js/conf/Debug.js b/js/conf/Debug.js index efd99fe..446be10 100644 --- a/js/conf/Debug.js +++ b/js/conf/Debug.js @@ -1,6 +1,6 @@ // Set prod to true when releasing -_prod = true; -// _prod = false; +// _prod = true; +_prod = false; Debug = { debug: true, diff --git a/js/lib/VideoData.js b/js/lib/VideoData.js index bbb73df..419029b 100644 --- a/js/lib/VideoData.js +++ b/js/lib/VideoData.js @@ -32,11 +32,16 @@ class VideoData { } startArDetection() { + if(!this.arDetector) { + this.arDetector.init(); + } this.arDetector.start(); } stopArDetection() { - this.arDetector.stop(); + if (this.arDetector) { + this.arDetector.stop(); + } } destroy() { From 8c9ee493a865b3798b61246ccb2a04585ea4b7ab Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Fri, 31 Aug 2018 00:38:03 +0200 Subject: [PATCH 2/2] fix --- CHANGELOG.md | 4 ++++ js/conf/Debug.js | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 82d6a49..d0608ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## v3.x +### v3.1.1 (Chrome-only) + +* Logging was accidentally left on in release version. This was fixed. + ### v3.1.0 * Fixed the issue where aspect ratio change wouldn't survive switching between fullscreen and non-fullscreen modes diff --git a/js/conf/Debug.js b/js/conf/Debug.js index 446be10..efd99fe 100644 --- a/js/conf/Debug.js +++ b/js/conf/Debug.js @@ -1,6 +1,6 @@ // Set prod to true when releasing -// _prod = true; -_prod = false; +_prod = true; +// _prod = false; Debug = { debug: true,