tamius-han/ultrawidify
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix

Browse Source
This commit is contained in:
Tamius Han 2019-09-22 02:49:40 +02:00
parent bf9ee47527
commit 2ad4e79bf3
5 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -21,6 +21,7 @@ QoL improvements for me:
* Reworked logging * Reworked logging
* Started using mutation observers to watch for changes in player size as well. Since mutation observers aren't entirely reliable, old way of doing things is still somewhat present as a backup way, but runs less frequently. * Started using mutation observers to watch for changes in player size as well. Since mutation observers aren't entirely reliable, old way of doing things is still somewhat present as a backup way, but runs less frequently.
* Implemented/improved/fixed settings patching * Implemented/improved/fixed settings patching
* **[4.3.0.1]** Removed some console.logs that I missed the first time around.
### v4.2.4 / 4.2.4.x ### v4.2.4 / 4.2.4.x

3
src/ext/lib/video-data/PlayerData.js
View File

@ -117,9 +117,7 @@ class PlayerData {
} }
async legacyChangeDetection() { async legacyChangeDetection() {
console.log("starting legacy cd")
while (!this.halted) { while (!this.halted) {
console.log("loop")
await this.sleep(1000); await this.sleep(1000);
try { try {
if (this.checkPlayerSizeChange()) { if (this.checkPlayerSizeChange()) {
@ -129,7 +127,6 @@ class PlayerData {
console.error('[playerdata::legacycd] this message is pretty high on the list of messages you shouldnt see', e); console.error('[playerdata::legacycd] this message is pretty high on the list of messages you shouldnt see', e);
} }
} }
console.log("HALTED - STOPPING CHANGE DETECTION FOR", this.element)
} }
stopChangeDetection(){ stopChangeDetection(){

2
src/ext/lib/video-data/VideoData.js
View File

@ -112,12 +112,10 @@ class VideoData {
// validate if current video still exists. If not, we destroy current object // validate if current video still exists. If not, we destroy current object
try { try {
if (! document.body.contains(this.video)) { if (! document.body.contains(this.video)) {
console.log("this video is having a bit of a hiatus:", this.video)
this.destroy(); this.destroy();
return; return;
} }
} catch (e) { } catch (e) {
console.log("e", e)
} }
// THIS BREAKS PANNING // THIS BREAKS PANNING
const cs = window.getComputedStyle(this.video); const cs = window.getComputedStyle(this.video);

2
src/manifest.json
View File

@ -2,7 +2,7 @@
"manifest_version": 2, "manifest_version": 2,
"name": "Ultrawidify", "name": "Ultrawidify",
"description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.", "description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.",
"version": "4.3.0", "version": "4.3.0.1",
"applications": { "applications": {
"gecko": { "gecko": {
"id": "{cf02b1a7-a01a-4e37-a609-516a283f1ed3}" "id": "{cf02b1a7-a01a-4e37-a609-516a283f1ed3}"

1
src/popup/panels/WhatsNewPanel.vue
View File

@ -11,6 +11,7 @@
<li>Started using mutation observers to watch for changes in player size as well, but with some caveats.</li> <li>Started using mutation observers to watch for changes in player size as well, but with some caveats.</li>
<li>Mutation observers are now used to detect both video and player size changes.</li> <li>Mutation observers are now used to detect both video and player size changes.</li>
<li>Settings patching has been reworked. Settings can now be patched incrementally.</li> <li>Settings patching has been reworked. Settings can now be patched incrementally.</li>
<li>[4.3.0.1] Removed some stray, forgotten console.logs.</li>
</ul> </ul>
<p>I'm also laying ground for some features that will make my life easier:</p> <p>I'm also laying ground for some features that will make my life easier:</p>
<ul> <ul>