Marking player now works (the div mark remains on top of yt videos). Todo: clear mark when popup goes away.

js/lib/Comms.js

@@ -87,8 +87,6 @@ class CommsClient {
     } else if (message.cmd === 'set-zoom') {
       this.pageInfo.setZoom(message.zoom, true, message.playing);
     } else if (message.cmd === 'mark-player') {
-      console.log("COMMS CLIENT MARKING PLAYER!")
-
       this.pageInfo.markPlayer(message.name, message.color);
     }
   }
@@ -348,7 +346,7 @@ class CommsServer {
     } else if (message.cmd === 'noVideo') {
       this.server.unregisterVideo(port.sender);
     } else if (message.cmd === 'mark-player') {
-      this.sendToFrame(message, this.tab, message.targetFrame);
+      this.sendToFrame(message, message.targetTab, message.targetFrame);
     }
   }
 

js/lib/PlayerData.js

@@ -70,10 +70,13 @@ class PlayerData {
   }
 
   markPlayer(name, color) {
-    console.log("PLAYERDATA — MARKING PLAYER!")
     var overlay = document.createElement('div');
     overlay.style.width = '100%';
     overlay.style.height = '100%';
+    overlay.style.position = 'absolute';
+    overlay.style.top = '0';
+    overlay.style.left = '0';
+    overlay.style.zIndex = '1000000000';
     overlay.innerHTML = `<div style="background-color: ${color}; color: #fff; position: absolute; top: 0; left: 0">${name}</div>`;
 
     this.overlayNode = overlay;

js/lib/VideoData.js

@@ -190,7 +190,6 @@ class VideoData {
   }
 
   markPlayer(name, color) {
-    console.log("VIDEO DATA — MARKING PLAYER!")
     if (this.player) {
       this.player.markPlayer(name, color)
     }

js/modules/PageInfo.js

@@ -420,8 +420,6 @@ class PageInfo {
   }
 
   markPlayer(name, color) { 
-    console.log("PAGEINFO — MARKING PLAYER!")
-
     for (var vd of this.videos) {
       vd.markPlayer(name,color);
     }

res/popup/js/popup.js

@@ -105,6 +105,7 @@ function loadFrames(videoTab) {
 
     port.postMessage({
       cmd: 'mark-player',
+      targetTab: videoTab.id,
       targetFrame: videoTab.frames[frame].id,
       name: videoTab.frames[frame].id,
       color: '#fa6'