From d8e3f39f2fb9a123c0ced04b23ea72ecd6541474 Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Thu, 6 Jun 2019 00:35:58 +0200 Subject: [PATCH 1/5] Updated readme --- CHANGELOG.md | 35 +++++++++++++++++++++++------------ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0531e48..1795403 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,24 +1,35 @@ # Changelog -## v4.x +## v4.x ### Plans for the future * Allow users to set autodetection sensitivity * Settings page looks ugly af right now. Maybe fix it some time later -### v4.0.0 (upcoming) +### v4.0.1 (current) + +* Fixed bug where sites using 'default' option in 'Extension mode' settings would be disabled, even if extension was not. +* Fixed bug where extension sometimes wouldn't work on Netflix. + +### v4.0.0 -* Using vue for popup and settings page -* Editable shortcuts -* Per-site controls -* You can now select which specific video on the page you control, provided each video is in its separate iframe -* Basic mode added -* Rewrote keyboard shortcuts and changed how they're handled. Massively. * Fixed the bug where saving settings wouldn't work -* Fixed the bug where autodetection didn't calculate aspect ratio correctly. This bug would manifest in this extension cropping too much video even in cases where edge between letterbox and video was clearly defined. -* Implemented/improved black frame detection -* Autodetection now differentiates between legitimate letterbox and linear gradients. This should prevent incorrect auto-cropping on videos that look similar to IGN's [Hollow Knight](https://www.youtube.com/watch?v=hg25ONutphA) review. +* Massive under-the-hood changes. The extension popup and settings page use VueJS +* **Autodetection improvements:** + * Autodetection tries to differentiate between gradients and hard edge and avoids correcting on gradients. This should help with videos that are similar to [IGN's review of Hollow Knight](https://www.youtube.com/watch?v=hg25ONutphA). + * Black frame detection has been implemented and improved. Some cases (but not all) of text on black background causing aspect ratio corrections have also been fixed. + * Autodetection frequency increased from roughly once every 0.6 seconds to about 3 checks per second. + * Fixed the bug where autodetectin didn't calculate aspect ratio correctly. This bug would manifest in extension cropping too much even though the edge was clearly defined. It most commonly occured in videos of aspect ratio <1 that contained letterbox. [ex 1]( https://www.youtube.com/watch?v=9DP0TbOQcOw), [ex 2](https://www.reddit.com/r/videos/comments/a137pj/daily_reminder_that_shelly_miscavige_wife_of/) + * Black frame detection has been implemented and improved. Some cases (but not all) of text on black background causing aspect ratio corrections have also been fixed. +* **Settings page was re-added** + * This includes a page for adding new aspect ratios and keyboard shortcuts. This feature is experimental. + * It's possible to tweak autodetection sensitivity and frequency. + * It's also possible to tweak autodetection settings in detail. + * It's now possible to reset settings to default +* Rewrote keyboard shortcuts and changed how they're handled. Massively. +* You can now select which specific video on the page you control, provided each video is in its separate iframe +* While I wasn't looking, Netflix started supporting ultrawide monitors on its own. Netflix' implementation clashes with my own, though, so I've decided to disable autodetection on videos that netflix already cropped on their own. Manual aspect ratio changes are still possible, but they're off. You've been warned. ## v3.x @@ -32,7 +43,7 @@ Never happened, got bumped to 4.0.0. -### v3.2.2 (current) +### v3.2.2 * Pan event listener now gets properly unbound * Fixed 'reset zoom' button in popup From 47e20721e6b6a7a9becfbc0a785d71c7856310f6 Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Mon, 24 Jun 2019 14:05:37 +0200 Subject: [PATCH 2/5] Reddit: detect player manually, fix site details popup --- src/ext/conf/ExtensionConf.js | 22 ++++++++++++++++++++++ src/popup/panels/SiteDetailsPanel.vue | 4 ++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/ext/conf/ExtensionConf.js b/src/ext/conf/ExtensionConf.js index be89945..02fc2b6 100644 --- a/src/ext/conf/ExtensionConf.js +++ b/src/ext/conf/ExtensionConf.js @@ -941,6 +941,28 @@ var ExtensionConf = { }, css: '', }, + "www.reddit.com" : { + mode: ExtensionMode.Enabled, + autoar: currentBrowser.firefox ? ExtensionMode.Enabled : ExtensionMode.Disabled, + override: false, + type: 'official', + stretch: Stretch.Default, + videoAlignment: VideoAlignment.Default, + keyboardShortcutsEnabled: ExtensionMode.Default, + DOM: { + video: { + manual: false, + querySelectors: '', + additionalCss: '', + }, + player: { + manual: true, + useRelativeAncestor: true, + videoAncestor: 1, + } + }, + css: '', + }, "vimeo.com": { mode: 3, autoar: 3, diff --git a/src/popup/panels/SiteDetailsPanel.vue b/src/popup/panels/SiteDetailsPanel.vue index c849662..31d3396 100644 --- a/src/popup/panels/SiteDetailsPanel.vue +++ b/src/popup/panels/SiteDetailsPanel.vue @@ -200,13 +200,13 @@ export default { toggleVideoManualQs() { this.ensureSettings('video'); this.videoManualQs = !this.videoManualQs; - this.settings.active.sites[this.site].DOM.video.enabled = this.videoManualQs; + this.settings.active.sites[this.site].DOM.video.manual = this.videoManualQs; this.settings.save(); }, togglePlayerManualQs() { this.ensureSettings('player'); this.playerManualQs = !this.playerManualQs; - this.settings.active.sites[this.site].DOM.player.enabled = this.playerManualQs; + this.settings.active.sites[this.site].DOM.player.manual = this.playerManualQs; this.settings.save(); }, toggleByNodeIndex() { From 5256a1bf19c6b9da044bafcf3adf59b88bafb35a Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Mon, 24 Jun 2019 14:26:43 +0200 Subject: [PATCH 3/5] readme update --- CHANGELOG.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index daf9d1b..3667e30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,12 @@ * Settings page looks ugly af right now. Maybe fix it some time later -### v4.1.1 (current) +### v4.1.2 (current) + +* Fixed video alignment issues on www.reddit as well (for people who use old reddit without going to old.reddit) +* Fixed bug with 'player detection' tab + +### v4.1.1 * Disabled gfycat From 1e4f32aee5c87541c819b34fc3a17b50a7da0d70 Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Mon, 24 Jun 2019 14:27:23 +0200 Subject: [PATCH 4/5] version bump --- package.json | 4 ++-- src/manifest.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 1c70862..fbfe990 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { - "name": "ultravidify-git", - "version": "4.0.0-a1", + "name": "ultravidify", + "version": "4.1.2", "description": "Aspect ratio fixer for youtube that works around some people's disability to properly encode 21:9 (and sometimes, 16:9) videos.", "author": "Tamius Han ", "scripts": { diff --git a/src/manifest.json b/src/manifest.json index e17eb59..3a305e3 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "Ultrawidify", "description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.", - "version": "4.1.1", + "version": "4.1.2", "applications": { "gecko": { "id": "{cf02b1a7-a01a-4e37-a609-516a283f1ed3}" From 67ffd483b623118009683c52aeb72c8077d70428 Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Mon, 24 Jun 2019 14:29:47 +0200 Subject: [PATCH 5/5] readme update but in popup --- src/popup/panels/WhatsNewPanel.vue | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/popup/panels/WhatsNewPanel.vue b/src/popup/panels/WhatsNewPanel.vue index 77e3a46..655998c 100644 --- a/src/popup/panels/WhatsNewPanel.vue +++ b/src/popup/panels/WhatsNewPanel.vue @@ -2,6 +2,11 @@

What's new

Full changelog for older versions is available here.

+

4.1.1 & 4.1.2

+
    +
  • Disabled extension on gfycat.
    • +
  • Fix for old.reddit.com applied to www.reddit.com
    • +

4.1.0

  • This