From c04780bb16601e02be18bdfa8422145bb4feb85b Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Thu, 24 Dec 2020 22:58:48 +0100 Subject: [PATCH] Make a comment explaining reversal to ensure we wont do that thing again --- src/ext/lib/video-transform/Resizer.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ext/lib/video-transform/Resizer.js b/src/ext/lib/video-transform/Resizer.js index eec7daa..3e0bc2c 100644 --- a/src/ext/lib/video-transform/Resizer.js +++ b/src/ext/lib/video-transform/Resizer.js @@ -672,6 +672,8 @@ class Resizer { styleArray.push(`transform: translate(${translate.x}px, ${translate.y}px) scale(${stretchFactors.xFactor}, ${stretchFactors.yFactor}) !important;`); // important — guarantees video will be properly aligned + // Note that position:absolute cannot be put here, otherwise old.reddit /w RES breaks — videos embedded + // from certain hosts will get a height: 0px. This is bad. styleArray.push("top: 0px !important; left: 0px !important; bottom: 0px !important; right: 0px;"); // important — some websites (cough reddit redesign cough) may impose some dumb max-width and max-height