From cd25cfbf8f36ae5d5948f66dd37b84f0baa4f73b Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Sun, 1 Sep 2019 03:23:19 +0200 Subject: [PATCH] minor fixes --- CHANGELOG.md | 2 +- src/ext/conf/ExtensionConf.js | 6 +++--- src/ext/lib/video-data/PlayerData.js | 4 ++-- src/manifest.json | 2 +- src/popup/panels/WhatsNewPanel.vue | 1 + 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d903c3..88743cd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ * Improvements to player detection. More details in the [blog post](https://stuff.tamius.net/sacred-texts/2019/08/31/ultrawidify-and-the-improper-cropping/). * **[4.2.4.1]** Fixed default video settings for reddit * **[4.2.4.1]** Manually specified query selectors will also be checked for compliance with player detection rules. - +* **[4.2.4.2]** Additional bugfixes. Updated/fixed default settings. ### v4.2.3 / 4.2.3.x diff --git a/src/ext/conf/ExtensionConf.js b/src/ext/conf/ExtensionConf.js index bf481c1..1a22de8 100644 --- a/src/ext/conf/ExtensionConf.js +++ b/src/ext/conf/ExtensionConf.js @@ -931,7 +931,7 @@ whatsNewChecked: true, }, "www.twitch.tv": { mode: ExtensionMode.Enabled, - autoar: currentBrowser.firefox ? ExtensionMode.Enabled : ExtensionMode.Disabled, + autoar: ExtensionMode.Enabled, override: true, type: 'official', stretch: Stretch.Default, @@ -965,7 +965,7 @@ whatsNewChecked: true, }, "old.reddit.com" : { mode: ExtensionMode.Enabled, - autoar: currentBrowser.firefox ? ExtensionMode.Enabled : ExtensionMode.Disabled, + autoar:ExtensionMode.Enabled, override: false, type: 'testing', stretch: Stretch.Default, @@ -982,7 +982,7 @@ whatsNewChecked: true, }, "www.reddit.com" : { mode: ExtensionMode.Enabled, - autoar: currentBrowser.firefox ? ExtensionMode.Enabled : ExtensionMode.Disabled, + autoar: ExtensionMode.Enabled, override: false, type: 'testing', stretch: Stretch.Default, diff --git a/src/ext/lib/video-data/PlayerData.js b/src/ext/lib/video-data/PlayerData.js index bd3538c..8fa7669 100644 --- a/src/ext/lib/video-data/PlayerData.js +++ b/src/ext/lib/video-data/PlayerData.js @@ -271,7 +271,7 @@ class PlayerData { const allSelectors = document.querySelectorAll(this.settings.active.sites[host].DOM.player.querySelectors); // actually we'll also score this branch in a similar way we score the regular, auto branch - while (element !== undefined) { + while (element) { // Let's see how this works if (this.collectionHas(allSelectors, element)) { @@ -305,7 +305,7 @@ class PlayerData { - while (element != undefined){ + while (element){ // odstranimo čudne elemente, ti bi pokvarili zadeve // remove weird elements, those would break our stuff if ( element.offsetWidth == 0 || element.offsetHeight == 0){ diff --git a/src/manifest.json b/src/manifest.json index b7c9529..1627c8f 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "Ultrawidify", "description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.", - "version": "4.2.4.1", + "version": "4.2.4.2", "applications": { "gecko": { "id": "{cf02b1a7-a01a-4e37-a609-516a283f1ed3}" diff --git a/src/popup/panels/WhatsNewPanel.vue b/src/popup/panels/WhatsNewPanel.vue index 7617692..2fd8b45 100644 --- a/src/popup/panels/WhatsNewPanel.vue +++ b/src/popup/panels/WhatsNewPanel.vue @@ -7,6 +7,7 @@
  • Improvements to player detection. More details in the blog post.
  • [4.2.4.1] Fixed default settings for reddit
  • [4.2.4.1] Manually specified query selectors are now also checked for compliance with player detection rules.
    • +
  • [4.2.4.2] Additional bugfixes. Updated/fixed default settings.

    • Chrome users: as a result of Chrome's shortcomings, there now exists one potential performance issue. If you notice any performance issues, please contact me via github, email or reddit (see: 'report a problem' tab