From 282f8350dd0f4ae1240d8f3b6dff8f1d04dbc41e Mon Sep 17 00:00:00 2001 From: EzzAK Date: Tue, 24 Sep 2019 22:10:36 -0700 Subject: [PATCH 1/4] Fix error for new users. --- src/ext/lib/Settings.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/ext/lib/Settings.js b/src/ext/lib/Settings.js index 34e6f7a..63bc22c 100644 --- a/src/ext/lib/Settings.js +++ b/src/ext/lib/Settings.js @@ -190,7 +190,14 @@ class Settings { // if there's no settings saved, return default settings. if(! settings || (Object.keys(settings).length === 0 && settings.constructor === Object)) { - this.logger.log('info', 'settings', '[Settings::init] settings don\'t exist. Using defaults.\n#keys:', Object.keys(settings).length, '\nsettings:', settings); + this.logger.log( + 'info', + 'settings', + '[Settings::init] settings don\'t exist. Using defaults.\n#keys:', + settings != null ? Object.keys(settings).length : 0, + '\nsettings:', + settings + ); this.active = this.getDefaultSettings(); this.active.version = this.version; await this.save(); From 20161207b9a21a6695ecfc34c44e93754c25e3bc Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Wed, 25 Sep 2019 09:34:14 +0200 Subject: [PATCH 2/4] just making presence check more in line with my style, otherwise this is fine --- src/ext/lib/Settings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ext/lib/Settings.js b/src/ext/lib/Settings.js index 63bc22c..ca68d9e 100644 --- a/src/ext/lib/Settings.js +++ b/src/ext/lib/Settings.js @@ -194,7 +194,7 @@ class Settings { 'info', 'settings', '[Settings::init] settings don\'t exist. Using defaults.\n#keys:', - settings != null ? Object.keys(settings).length : 0, + settings ? Object.keys(settings).length : 0, '\nsettings:', settings ); From b70cc7bb8859343af97bdad91a0e7afd6ac4f3a3 Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Wed, 25 Sep 2019 09:59:44 +0200 Subject: [PATCH 3/4] Update readme with correct build instructions --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f2c8d1e..3c3f825 100644 --- a/README.md +++ b/README.md @@ -245,16 +245,16 @@ However, I do plan on implementing this feature. Hopefully by the end of the yea ### Installing the current, github version -Requirements: npm, yarn. +Requirements: npm, node. 1. Clone this repo -2. run `yarn install` -3. run `npm run watch:dev` +2. run `npm install` +3. If using **Firefox,** run: `npm run watch:dev`. If using **Chrome,** run: `npm run watch-chrome:dev`. If using Edge, run: `npm run watch-edge:dev`. TODO: see if #3 already loads the extension in FF -2. Open up Firefox -3. Go to `about:debugging` +2. Open up Firefox (or Chrome) +3. Go to `about:debugging` (or Chrome equivalent) 4. Add temporary addon 5. Select `${ultrawidify_folder}/dist/manifest.json` From 4e67902c5624e94e870cd2e6ac10acc800010fab Mon Sep 17 00:00:00 2001 From: Tamius Han Date: Wed, 25 Sep 2019 18:44:01 +0200 Subject: [PATCH 4/4] version update stuff --- CHANGELOG.md | 1 + src/manifest.json | 2 +- src/popup/panels/WhatsNewPanel.vue | 5 +++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ab1b25..cdcf01f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ QoL improvements for me: * Started using mutation observers to watch for changes in player size as well. Since mutation observers aren't entirely reliable, old way of doing things is still somewhat present as a backup way, but runs less frequently. * Implemented/improved/fixed settings patching * **[4.3.0.1]** Removed some console.logs that I missed the first time around. +* **[4.3.0.2]** Extension would not work for new users. (Special thanks to [ezzak](https://github.com/ezzak) for finding and submitting a patch) ### v4.2.4 / 4.2.4.x diff --git a/src/manifest.json b/src/manifest.json index 34705b8..22a0b8e 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "Ultrawidify", "description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.", - "version": "4.3.0.1", + "version": "4.3.0.2", "applications": { "gecko": { "id": "{cf02b1a7-a01a-4e37-a609-516a283f1ed3}" diff --git a/src/popup/panels/WhatsNewPanel.vue b/src/popup/panels/WhatsNewPanel.vue index ee14d83..cef61dd 100644 --- a/src/popup/panels/WhatsNewPanel.vue +++ b/src/popup/panels/WhatsNewPanel.vue @@ -2,8 +2,10 @@

What's new

Full changelog for older versions is available here.

-

4.3.0

+

4.3.0.2

    +
  • [4.3.0.2] Extension would not work for new users. (Special thanks to [ezzak](https://github.com/ezzak) for finding and submitting a patch)
    • +
  • [4.3.0.1] Removed some stray, forgotten console.logs.
  • Fixed an issue where videos would get incorrectly aligned following a window resize.
  • Fixed all sorts of issues for videos hosted on v.reddit for new (and old) reddit
  • Fixed the issue where setting extension to 'whitelist only' would disable 'site settings' in popup.
    • @@ -11,7 +13,6 @@
  • Started using mutation observers to watch for changes in player size as well, but with some caveats.
  • Mutation observers are now used to detect both video and player size changes.
  • Settings patching has been reworked. Settings can now be patched incrementally.
    • -
  • [4.3.0.1] Removed some stray, forgotten console.logs.

I'm also laying ground for some features that will make my life easier: