tamius-han/ultrawidify
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix setBaseClass function

Browse Source
This commit is contained in:
Tamius Han 2020-11-05 23:55:42 +01:00
parent 6b91444f3c
commit f8e3a39620
1 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/ext/lib/video-data/PlayerData.js
View File

@ -79,16 +79,29 @@ class PlayerData {
// be better option than doing nothing // be better option than doing nothing
return; return;
} }
// note that we should never allow both narrow-screen and wide-screen classes on the video // note that we should never allow both narrow-screen and wide-screen classes on the video
// element at _any_ time. That may break some sites even more. // element at _any_ time. That may break some sites even more.
// We should also only set/unset css classes when they change, otherwise mutation observer
// will trigger. Triggering mutation observer is problematic because this function may be
// called from said mutation observer, and that is bad.
if (this.video.videoWidth / this.videoHeight <= this.dimensions.width / this.dimensions.height) {
this.video.classList.remove('uw-ultrawidify-base-narrow-screen'); const isNarrowScreen = this.video.videoWidth / this.video.videoHeight > this.dimensions.width / this.dimensions.height;
this.video.classList.add('uw-ultrawidify-base-wide-screen');
} else { console.warn('setting base class. Is narrow screen?', isNarrowScreen, 'was narrow screen?', this.isNarrowScreen, "video:", this.video, ":", this.video.videoWidth, "x", this.video.videoHeight, "video file ar:", this.video.videoWidth / this.video.videoHeight, "player ar:", this.dimensions.width / this.dimensions.height)
this.video.classList.remove('uw-ultrawidify-base-wide-screen');
this.video.classList.add('uw-ultrawidify-base-narrow-screen'); if (this.isNarrowScreen != isNarrowScreen) {
if (!isNarrowScreen) {
this.video.classList.remove('uw-ultrawidify-base-narrow-screen');
this.video.classList.add('uw-ultrawidify-base-wide-screen');
} else {
this.video.classList.remove('uw-ultrawidify-base-wide-screen');
this.video.classList.add('uw-ultrawidify-base-narrow-screen');
}
} }
this.isNarrowScreen = isNarrowScreen;
} }
unsetBaseClass() { unsetBaseClass() {