Account for offset applied by sites that use top:50%/transformY:-50% to center elements

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "ultrawidify",
-  "version": "6.0.2",
+  "version": "6.2.0",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultrawidify",
-  "version": "6.0.2",
+  "version": "6.2.0",
   "description": "Aspect ratio fixer for youtube and other sites, with automatic aspect ratio detection. Supports ultrawide and other ratios.",
   "author": "Tamius Han <tamius.han@gmail.com>",
   "scripts": {

src/csui/src/PlayerUiPanels/PlayerDetectionPanel.vue

@@ -1,23 +1,17 @@
 <template>
-  <div class="flex flex-col tab-root">
-    <!-- ADD ANY OPTION BARS HERE -->
-
-    <!-- The rest of the tab -->
-    <div class="flex flex-row flex-wrap">
-
-      <!-- Player element picker -->
-      <div class="sub-panel">
+  <div class="flex flex-col">
     <div class="flex flex-row">
-          <h1><mdicon name="television-play" :size="32" /> Player element</h1>
+      <h1>Video player options</h1>
     </div>
     <div class="flex flex-row">
+      <div style="width: 48%">
+        NEW PLAYER SELECTOR
         <div class="sub-panel-content">
           <p>
             You're probably on this page because Ultrawidify doesn't crop the player correctly.
           </p>
           <p>
-              If you hover over the boxes below, the corresponding element will change (sepia filter + higher brightness + reduced contrast + it gets an outline). Player element
-              should be the closest element to the video element, for which the sepia/brightness effect covers the area you expect the video will cover.
+            If you hover over the boxes below, the corresponding element will be highlighted with golden outline. Player should be the first element that covers the video player on the page.
           </p>
           <p>
             You need to reload the page for changes to take effect.
@@ -340,14 +334,102 @@
             </div> -->
           </div>
         </div>
+      </div>
+      <div style="width: 48%">
+        <div>EXAMPLE <small style="opacity: 0.5"><br/>ps: i know this ui is shit, no need to tell me</small></div>
+        <div class="demo-images">
+          <div class="fig1">
+            <img src="/res/img/player-select-demo/uw_player_select___too_little.webp" />
+            <div>If you see this when hovering over the element, you need to select further down the list.</div>
+          </div>
+          <div class="fig2">
+            <div>
+              <p>
+                If you see this when hovering over the element, you're hovering over the correct element.
+              </p>
+              <p>
+                In case there's more than one element that covers the entire player and nothing more, select the option that's closest to the top of the list, otherwise in-player UI could break.
+              </p>
+              <p>
+                If in-player UI breaks, you can make the settings window appear from the extension popup.
+              </p>
+              </div>
+            <img src="/res/img/player-select-demo/uw_player_select___just-right.webp" />
+          </div>
+          <div class="fig1">
+            <img src="/res/img/player-select-demo/uw_player_select___too_much.webp" />
+            <div>If you see this when hovering over the element, you need to select an element closer to the top of the list.</div>
+          </div>
+        </div>
+      </div>
+      <div style="width: 48%" v-if="false">
+        <h2>Legacy advanced settings</h2>
+
+        <div class="">
+          <h3>Player element</h3>
+          <div class="field">
+            <div class="label">Manually specify player</div>
+            <input type="checkbox" />
+          </div>
+          <div class="field">
+            <div class="label">Select player by/as:</div>
+            <div class="select">
+              <select>
+                <option>n-th parent of video</option>
+                <option>Query selectors</option>
+              </select>
+            </div>
+          </div>
+          <div class="field">
+            <div class="label">Player is n-th parent of video</div>
+            <div class="range-input">
+              <input type="range" min="0" max="100" />
+              <input />
+            </div>
+          </div>
+          <div class="field">
+            <div class="label">Query selector for player element</div>
+            <div class="input">
+              <input />
+            </div>
+          </div>
+          <div class="field">
+            <div class="label">In full screen, calculate crop based on monitor resolution</div>
+            <input type="checkbox" />
+          </div>
+
+          <h3>Video element</h3>
+          <div class="field">
+            <div class="label">Select video element automatically</div>
+            <input type="checkbox">
+          </div>
+          <div class="field">
+            <div class="label">Query selectors</div>
+            <div class="input">
+              <input>
+            </div>
+          </div>
+          <div class="field">
+            <div class="label">Additional styles for video element</div>
+            <div class="input">
+              <textarea></textarea>
+            </div>
+          </div>
+
+          <h3>Additional css for this page</h3>
+          <div class="field">
+            <div class="label">Additional CSS for this page</div>
+            <textarea></textarea>
+          </div>
+
+        </div>
+      </div>
 
       <!-- <div class="sub-panel-content">
         <h2>Advanced settings</h2>
       </div> -->
     </div>
   </div>
-    </div>
-  </div>
 </template>
 <script>
 
@@ -467,6 +549,9 @@ export default({
 })
 </script>
 
+<style lang="scss" src="../../res/css/flex.scss" scoped module></style>
+<style lang="scss" src="../res-common/panels.scss" scoped module></style>
+<style lang="scss" src="../res-common/common.scss" scoped module></style>
 <style lang="scss" scoped>
 p {
   font-size: 1rem;
@@ -575,4 +660,32 @@ p {
 .tab-root {
   width: 100%;
 }
+
+.demo-images {
+  width: 100%;
+  display: flex;
+  flex-direction: column;
+
+  padding-top: 2rem;
+
+  .fig1, .fig2 {
+    margin-top: -2rem;
+    max-height: 18rem;
+    width: 100%;
+
+    display: flex;
+    flex-direction: row;
+    align-items: center;
+  }
+  .fig1 {
+    align-self: start;
+  }
+  .fig2 {
+    align-self: end;
+  }
+
+  img {
+    max-width: 32rem;
+  }
+}
 </style>

src/ext/conf/ExtConfPatches.ts

@@ -11,14 +11,15 @@ import AspectRatioType from '../../common/enums/AspectRatioType.enum';
 
 const ExtensionConfPatch = [
   {
-    forVersion: '6.0.1-1',
+    forVersion: '6.1.1',
     updateFn: (userOptions: SettingsInterface, defaultOptions) => {
       // add new commands
       userOptions.commands = defaultOptions.commands;
+      userOptions.actions = defaultOptions.actions;
     }
   }, {
     // NOTE - when releasing shit, ensure ALL alpha migrations are combined together in one function
-    forVersion: '6.0.1-2',
+    forVersion: '6.1.2',
     updateFn: (userOptions, defaultOptions) => {
       userOptions.commands = defaultOptions.commands;
 
@@ -89,7 +90,7 @@ const ExtensionConfPatch = [
       }
     }
   }, {
-    forVersion: '6.0.1-3',
+    forVersion: '6.0.3',
     updateFn: (userOptions: SettingsInterface, defaultOptions) => {
       delete (userOptions as any).sites['@global'].persistOption;
       delete (userOptions as any).sites['@empty'].persistOption;
@@ -98,7 +99,7 @@ const ExtensionConfPatch = [
       userOptions.sites['@empty'].persistCSA = CropModePersistence.Disabled;
     }
   },  {
-    forVersion: '6.0.1-4',
+    forVersion: '6.0.4',
     updateFn: (userOptions: SettingsInterface, defaultOptions) => {
 
       // deprecated much?
@@ -110,36 +111,36 @@ const ExtensionConfPatch = [
           arg: AspectRatioType.Cycle
         }]
       });
-      userOptions.commands.crop.push({
-        action: 'set-ar',
-        label: 'Cycle',
-        comment: 'Cycle through crop options',
-        arguments: {
-          type: AspectRatioType.Cycle
-        },
-        shortcut: {
-          key: 'c',
-          code: 'KeyC',
-          ctrlKey: false,
-          metaKey: false,
-          altKey: false,
-          shiftKey: false,
-          onKeyUp: true,
-          onKeyDown: false,
-        }
-      });
-      userOptions.commands.crop.push({
-        action: 'set-ar',
-        label: '32:9',
-        comment: 'Crop for 32:9 aspect ratio',
-        arguments: {
-          type: AspectRatioType.Fixed,
-          ratio: 3.56
-        },
-      })
+      // userOptions.commands.crop.push({
+      //   action: 'set-ar',
+      //   label: 'Cycle',
+      //   comment: 'Cycle through crop options',
+      //   arguments: {
+      //     type: AspectRatioType.Cycle
+      //   },
+      //   shortcut: {
+      //     key: 'c',
+      //     code: 'KeyC',
+      //     ctrlKey: false,
+      //     metaKey: false,
+      //     altKey: false,
+      //     shiftKey: false,
+      //     onKeyUp: true,
+      //     onKeyDown: false,
+      //   }
+      // });
+      // userOptions.commands.crop.push({
+      //   action: 'set-ar',
+      //   label: '32:9',
+      //   comment: 'Crop for 32:9 aspect ratio',
+      //   arguments: {
+      //     type: AspectRatioType.Fixed,
+      //     ratio: 3.56
+      //   },
+      // })
     }
   }, {
-    forVersion: '6.0.1-5',
+    forVersion: '6.1.5',
     updateFn: (userOptions: SettingsInterface, defaultOptions) => {
       if (!userOptions.sites['@global'].defaults.alignment || !userOptions.sites['@global'].defaults.alignment.x || !userOptions.sites['@global'].defaults.alignment.y) {
         userOptions.sites['@global'].defaults.alignment = {
@@ -150,7 +151,7 @@ const ExtensionConfPatch = [
       userOptions.sites['@empty'].defaults.alignment = {x: VideoAlignmentType.Default, y: VideoAlignmentType.Default};
     }
   }, {
-    forVersion: '6.0.1-6',
+    forVersion: '6.1.1-6',
     updateFn: (userOptions: SettingsInterface, defaultOptions) => {
       for (const site in userOptions.sites) {
         userOptions.sites[site].defaultType = userOptions.sites[site].type as any;
@@ -159,7 +160,7 @@ const ExtensionConfPatch = [
       userOptions.sites['@empty'].defaultType = 'modified';
     }
   }, {
-    forVersion: '6.0.2-0',
+    forVersion: '6.1.2-0',
     updateFn: (userOptions: SettingsInterface, defaultOptions) => {
       // remove custom CSS, as it is no longer needed
       for (const site in userOptions.sites) {
@@ -185,6 +186,13 @@ const ExtensionConfPatch = [
       },
       userOptions.newFeatureTracker['uw6.ui-popup'] = {show: 10};
     }
+  }, {
+    forVersion: '6.1.9',
+    updateFn: (userOptions: SettingsInterface, defaultOptions) => {
+      userOptions.ui = defaultOptions.ui;
+      userOptions.arDetect = defaultOptions.arDetect;
+      userOptions.newFeatureTracker = defaultOptions.newFeatureTracker;
+    }
   }
 ];
 

src/ext/lib/EventBus.ts

@@ -110,7 +110,6 @@ export default class EventBus {
    * @param config
    */
   sendToTunnel(command: string, config: any) {
-    console.log('sending to tunnel from eventBus ....', this)
     if (!this.disableTunnel) {
       window.parent.postMessage(
         {

src/ext/lib/Settings.ts

@@ -183,6 +183,7 @@ class Settings {
     }
 
     // apply all remaining patches
+    try {
       this.logger?.log('info', 'settings', `[Settings::applySettingsPatches] There are ${patches.length - index} settings patches to apply`);
       while (index < patches.length) {
         const updateFn = patches[index].updateFn;
@@ -204,6 +205,10 @@ class Settings {
 
         index++;
       }
+    } catch (e) {
+      this.setActive(this.getDefaultSettings());
+      this.save();
+    }
   }
 
   async init() {

src/ext/lib/aard/Aard.ts

@@ -1801,7 +1801,6 @@ export class Aard {
     }
 
     this.testResults.aspectRatioUncertain = false;
-    console.log('Updating letterboxWidth - as normal')
 
     this.testResults.letterboxWidth = candidateAvg;
     this.testResults.letterboxOffset = diff;

src/ext/lib/video-data/PlayerData.ts

@@ -89,6 +89,7 @@ class PlayerData {
   private observer: ResizeObserver;
 
   private trackChangesTimeout: any;
+  private markedElement: HTMLElement;
 
   private ui: UI;
 
@@ -741,8 +742,37 @@ class PlayerData {
   }
 
   private markElement(data: {parentIndex: number, enable: boolean}) {
-    this.elementStack[data.parentIndex].element.style.outline = data.enable ? '5px dashed #fa6' : null;
-    this.elementStack[data.parentIndex].element.style.filter = data.enable ? 'sepia(1) brightness(2) contrast(0.5)' : null;
+    if (data.enable === false) {
+      this.markedElement.remove();
+      return;
+    }
+
+
+    if (this.markedElement) {
+      this.markedElement.remove();
+    }
+
+    const elementBB = this.elementStack[data.parentIndex].element.getBoundingClientRect();
+
+    // console.log('element bounding box:', elementBB);
+
+    const div = document.createElement('div');
+    div.style.position = 'fixed';
+    div.style.top = `${elementBB.top}px`;
+    div.style.left = `${elementBB.left}px`;
+    div.style.width = `${elementBB.width}px`;
+    div.style.height = `${elementBB.height}px`;
+    div.style.zIndex = '100';
+    div.style.border = '5px dashed #fa6';
+    div.style.pointerEvents = 'none';
+    div.style.boxSizing = 'border-box';
+    div.style.backgroundColor = 'rgba(255, 128, 64, 0.25)';
+
+    document.body.insertBefore(div, document.body.firstChild);
+    this.markedElement = div;
+
+    // this.elementStack[data.parentIndex].element.style.outline = data.enable ? '5px dashed #fa6' : null;
+    // this.elementStack[data.parentIndex].element.style.filter = data.enable ? 'sepia(1) brightness(2) contrast(0.5)' : null;
   }
 
   forceRefreshPlayerElement() {

src/ext/lib/video-transform/Resizer.ts

@@ -50,7 +50,7 @@ class Resizer {
   //#endregion
 
   //#region HTML elements
-  video: any;
+  video: HTMLVideoElement;
   //#endregion
 
   //#region data
@@ -692,6 +692,7 @@ class Resizer {
     this.logger.log('info', 'debug', "[Resizer::computeOffsets] <rid:"+this.resizerId+"> video will be aligned to ", this.videoAlignment);
 
     const {realVideoWidth, realVideoHeight, marginX, marginY} = this.computeVideoDisplayedDimensions();
+    const computedStyles = getComputedStyle(this.video);
 
     // correct any remaining element size discrepancies (applicable only to certain crop strategies!)
     // NOTE: it's possible that we might also need to apply a similar measure for CropPillarbox strategy
@@ -715,8 +716,8 @@ class Resizer {
     // we only need to compensate if alignment is set to anything other than center center
     // compensation is equal to half the difference between (zoomed) video size and player size.
     const translate = {
-      x: 0,
-      y: 0,
+      x: -Math.round(+ (computedStyles.left.replace('px', ''))),
+      y: -Math.round(+ (computedStyles.top.replace('px', '')))
     };
 
     // NOTE: manual panning is probably broken now.
@@ -887,17 +888,6 @@ class Resizer {
     // add remaining elements
     if (stretchFactors) {
       styleArray.push(`transform: translate(${Math.round(translate.x)}px, ${Math.round(translate.y)}px) scale(${stretchFactors.xFactor}, ${stretchFactors.yFactor}) !important;`);
-
-      // important — guarantees video will be properly aligned
-      // Note that position:absolute cannot be put here, otherwise old.reddit /w RES breaks — videos embedded
-      // from certain hosts will get a height: 0px. This is bad.
-      // styleArray.push("top: 0px !important; left: 0px !important; bottom: 0px !important; right: 0px;");
-
-      // important — some websites (cough reddit redesign cough) may impose some dumb max-width and max-height
-      // restrictions. If site has dumb shit like 'max-width: 100%' and 'max-height: 100vh' in their CSS, that
-      // shit will prevent us from applying desired crop. This means we need to tell websites to fuck off with
-      // that crap. We know better.
-      // styleArray.push("max-width: none !important; max-height: none !important;");
     }
     const styleString = `${this.buildStyleString(styleArray)}${extraStyleString || ''}`; // string returned by buildStyleString() should end with ; anyway
 

src/manifest.json

@@ -2,7 +2,7 @@
   "manifest_version": 3,
   "name": "Ultrawidify",
   "description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.",
-  "version": "6.0.2",
+  "version": "6.2.0",
   "icons": {
     "32":"res/icons/uw-32.png",
     "64":"res/icons/uw-64.png"

src/options/about.vue

@@ -63,7 +63,7 @@ Browser-related stuff (please ensure this section is correct):
 `
       );
     this.mailtoLink = `mailto:tamius.han@gmail.com?subject=%5BUltrawidify%5D%20ENTER%20SUMMARY%20OF%20YOUR%20ISSUE%20HERE&body=${messageTemplate}`;
-    this.redditLink = `https://www.reddit.com/message/compose?to=xternal7&subject=[Ultrawidify]%20ENTER%20SUMMARY%20OF%20YOUR%20PROBLEM%20HERE&message=${messageTemplate}`;
+    // this.redditLink = `https://www.reddit.com/message/compose?to=xternal7&subject=[Ultrawidify]%20ENTER%20SUMMARY%20OF%20YOUR%20PROBLEM%20HERE&message=${messageTemplate}`;
   }
 }
 </script>