Merge branch 'master' into stable

CHANGELOG.md

@@ -22,6 +22,7 @@ QoL improvements for me:
 * Started using mutation observers to watch for changes in player size as well. Since mutation observers aren't entirely reliable, old way of doing things is still somewhat present as a backup way, but runs less frequently.
 * Implemented/improved/fixed settings patching
 * **[4.3.0.1]** Removed some console.logs that I missed the first time around.
+* **[4.3.0.2]** Extension would not work for new users. (Special thanks to [ezzak](https://github.com/ezzak) for finding and submitting a patch)
 
 ### v4.2.4 / 4.2.4.x
 

README.md

@@ -245,16 +245,16 @@ However, I do plan on implementing this feature. Hopefully by the end of the yea
 
 ### Installing the current, github version
 
-Requirements: npm, yarn.
+Requirements: npm, node.
 
 1. Clone this repo
-2. run `yarn install`
+2. run `npm install`
-3. run `npm run watch:dev`
+3. If using **Firefox,** run: `npm run watch:dev`. If using **Chrome,** run: `npm run watch-chrome:dev`. If using Edge, run: `npm run watch-edge:dev`.
 
 TODO: see if #3 already loads the extension in FF
 
-2. Open up Firefox
+2. Open up Firefox (or Chrome)
-3. Go to `about:debugging`
+3. Go to `about:debugging` (or Chrome equivalent)
 4. Add temporary addon
 5. Select `${ultrawidify_folder}/dist/manifest.json`
 

src/ext/lib/Settings.js

@@ -190,7 +190,14 @@ class Settings {
 
     // if there's no settings saved, return default settings.
     if(! settings || (Object.keys(settings).length === 0 && settings.constructor === Object)) {
-      this.logger.log('info', 'settings', '[Settings::init] settings don\'t exist. Using defaults.\n#keys:', Object.keys(settings).length, '\nsettings:', settings);
+      this.logger.log(
+        'info', 
+        'settings', 
+        '[Settings::init] settings don\'t exist. Using defaults.\n#keys:', 
+        settings ? Object.keys(settings).length : 0, 
+        '\nsettings:', 
+        settings
+      );
       this.active = this.getDefaultSettings();
       this.active.version = this.version;
       await this.save();

src/manifest.json

@@ -2,7 +2,7 @@
   "manifest_version": 2,
   "name": "Ultrawidify",
   "description": "Removes black bars on ultrawide videos and offers advanced options to fix aspect ratio.",
-  "version": "4.3.0.1",
+  "version": "4.3.0.2",
   "applications": {
     "gecko": {
       "id": "{cf02b1a7-a01a-4e37-a609-516a283f1ed3}"

src/popup/panels/WhatsNewPanel.vue

@@ -2,8 +2,10 @@
   <div>
     <h2>What's new</h2>
     <p>Full changelog for older versions <a href="https://github.com/xternal7/ultrawidify/blob/master/CHANGELOG.md">is available here</a>.</p>
-    <p class="label">4.3.0</p>
+    <p class="label">4.3.0.2</p>
     <ul>
+      <li><b>[4.3.0.2]</b> Extension would not work for new users. (Special thanks to [ezzak](https://github.com/ezzak) for finding and submitting a patch)</li>
+      <li><b>[4.3.0.1]</b> Removed some stray, forgotten console.logs.</li>
       <li>Fixed an issue where videos would get incorrectly aligned following a window resize.</li>
       <li>Fixed all sorts of issues for videos hosted on v.reddit for new (and old) reddit</li>
       <li>Fixed the issue where setting extension to 'whitelist only' would disable 'site settings' in popup.</li>
@@ -11,7 +13,6 @@
       <li>Started using mutation observers to watch for changes in player size as well, but with some caveats.</li>
       <li>Mutation observers are now used to detect both video and player size changes.</li>
       <li>Settings patching has been reworked. Settings can now be patched incrementally.</li>
-      <li>[4.3.0.1] Removed some stray, forgotten console.logs.</li>
     </ul>
     <p>I'm also laying ground for some features that will make my life easier:</p>
     <ul>